20 Sep
2019
20 Sep
'19
5:12 p.m.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35484 )
Change subject: util/smc: Add and use new tool smcbiosinfo ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35484/5/src/vendorcode/smc/Makefile... File src/vendorcode/smc/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35484/5/src/vendorcode/smc/Makefile... PS5, Line 11: $(build_h) consider passing the data into the tool through command line arguments
https://review.coreboot.org/c/coreboot/+/35484/5/src/vendorcode/smc/Makefile... PS5, Line 11: $(SMCBIOSINFOTOOL): util/smc/smcbiosinfo/smcbiosinfo.c $(build_h) put that stuff in util/**/Makefile.inc
--
To view, visit https://review.coreboot.org/c/coreboot/+/35484
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id608c2ce78614b45a2fd0b26d97d666f02223998
Gerrit-Change-Number: 35484
Gerrit-PatchSet: 5
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Fri, 20 Sep 2019 15:12:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment