Attention is currently required from: Felix Singer, Jonathan Neuschäfer, Christoph Pomaska. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62569 )
Change subject: RFC: Add initial support for the bootguarded framework tigerlake laptop (hx20) ......................................................................
Patch Set 5: Verified+1
(5 comments)
File src/mainboard/framework/tgl_laptop/Kconfig:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144420): https://review.coreboot.org/c/coreboot/+/62569/comment/de050c34_fa2e5fd5 PS5, Line 1: if BOARD_FRAMWORK_TGL 'FRAMWORK' may be misspelled - perhaps 'FRAMEWORK'?
File src/mainboard/framework/tgl_laptop/Kconfig.name:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144420): https://review.coreboot.org/c/coreboot/+/62569/comment/fbf7aeb7_e61dd014 PS5, Line 1: config BOARD_FRAMWORK_TGL 'FRAMWORK' may be misspelled - perhaps 'FRAMEWORK'?
File src/mainboard/framework/tgl_laptop/romstage.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144420): https://review.coreboot.org/c/coreboot/+/62569/comment/e6336293_c7bf5b2a PS5, Line 17: { that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144420): https://review.coreboot.org/c/coreboot/+/62569/comment/60fb1cd5_7daedcaa PS5, Line 19: { that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144420): https://review.coreboot.org/c/coreboot/+/62569/comment/ad398ac1_66bd402e PS5, Line 23: { that open brace { should be on the previous line