Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38547 )
Change subject: Device enumeration based on IORESOURCE_ASSIGNED
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38547/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38547/2//COMMIT_MSG@7
PS2, Line 7: Device enumeration based on IORESOURCE_ASSIGNED
Maybe: […]
Done
https://review.coreboot.org/c/coreboot/+/38547/2/src/device/device.c
File src/device/device.c:
https://review.coreboot.org/c/coreboot/+/38547/2/src/device/device.c@440
PS2, Line 440: round(bridge->base, bridge->align);
I guess this was changed back and forth when trying things out? In any case, it would fit on a singl […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38547
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69e100ea658fefec905321197b5bd6da1e0e647a
Gerrit-Change-Number: 38547
Gerrit-PatchSet: 2
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Petrov
anpetrov@fb.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 25 Jan 2020 19:15:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment