Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35027 )
Change subject: mb/ocp/monolake: Add ACPI HPET table ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35027/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35027/1//COMMIT_MSG@10 PS1, Line 10: please add this was tested, i.e TEST=note kernel log clocksource switch to hpet
https://review.coreboot.org/c/coreboot/+/35027/1/src/mainboard/ocp/monolake/... File src/mainboard/ocp/monolake/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35027/1/src/mainboard/ocp/monolake/... PS1, Line 85: /* Enable access to the BMC IPMI via KCS */ this code is not mainboard-specific and should go to SoC. Could you please move this code to soc/intel/fsp_broadwell_de/southcluster.c ? Just add write_acpi_tables ops.