[coreboot-gerrit] Change in coreboot[master]: {drivers,mainboard}: Move FSP logo support to fsp1_1

[Wim Vervoorn (Code Review)]

Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36679 )

Change subject: {drivers,mainboard}: Move FSP logo support to fsp1_1
......................................................................

Patch Set 10:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36679/7/src/drivers/intel/fsp1_1/Kc... 
File src/drivers/intel/fsp1_1/Kconfig:

https://review.coreboot.org/c/coreboot/+/36679/7/src/drivers/intel/fsp1_1/Kc... 
PS7, Line 107: FSP1_1_DISPLAY_LOGO
> The message has been changed and the increased .bss usage has been resolved. […]

Done

https://review.coreboot.org/c/coreboot/+/36679/4/src/drivers/intel/fsp1_1/lo... 
File src/drivers/intel/fsp1_1/logo.c:

https://review.coreboot.org/c/coreboot/+/36679/4/src/drivers/intel/fsp1_1/lo... 
PS4, Line 26: !logo_data_sz
> why? do you expect to call this function multiple times?

The code was made with BGRT support in mind (this would indeed cause multiple calls similar to the VBT case). As this is not supported it should have been removed.