Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42810 )
Change subject: soc/amd/picasso: Halt if workbuf is absent after psp_verstage ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42810/2/src/soc/amd/picasso/bootblo... File src/soc/amd/picasso/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/42810/2/src/soc/amd/picasso/bootblo... PS2, Line 17: bot
not
Done
https://review.coreboot.org/c/coreboot/+/42810/2/src/soc/amd/picasso/bootblo... PS2, Line 132: #include <2struct.h>
Why the include again?
Just forgot to remove it when I moved it above. I initially tried putting it here so we only had one #if , but it blew up being included inside the function.
Removed.
https://review.coreboot.org/c/coreboot/+/42810/2/src/soc/amd/picasso/bootblo... PS2, Line 133: CONFIG_PSP_SHAREDMEM_BASE
Can we use the symbol defined in the mamlayout. […]
Done