Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39343 )
Change subject: vboot: remove extraneous vboot_recovery_mode_memory_retrain
......................................................................
Patch Set 1: -Code-Review
(1 comment)
https://review.coreboot.org/c/coreboot/+/39343/1/src/drivers/intel/fsp2_0/me...
File src/drivers/intel/fsp2_0/memory_init.c:
https://review.coreboot.org/c/coreboot/+/39343/1/src/drivers/intel/fsp2_0/me...
PS1, Line 120: if (get_recovery_mode_retrain_switch()) {
Hmmm? I think you don't want to change this one.
That's right.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39343
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icb88d6862db1782e0218276984e527638b21fd3a
Gerrit-Change-Number: 39343
Gerrit-PatchSet: 1
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 07 Mar 2020 01:13:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment