Attention is currently required from: Arthur Heymans. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37197 ) Change subject: drivers/amd/agesa/romstage: Only mark cbmem as UC if needed ...................................................................... Patch Set 17: Code-Review+1 (1 comment) File src/drivers/amd/agesa/mtrr_fixme.c: https://review.coreboot.org/c/coreboot/+/37197/comment/db517a55_910b05b5 PS17, Line 48: /* TODO: Don't all AGESA platforms supported CLFLUSH ? */ According to BKDG for fam14 and newer CLFLUSH is supported. Haven't checked older families as they are not in current master. Also the BKDGs explicitly state that CLFLUSH may be used to migrate data to memory after BIOS initializes the DRAM and is done with using CAR. I think it is safe to remove this comment. -- To view, visit https://review.coreboot.org/c/coreboot/+/37197 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaa0d154e2c5b2052027d07ad26e31f3ff63ae9f3 Gerrit-Change-Number: 37197 Gerrit-PatchSet: 17 Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski@3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Comment-Date: Thu, 02 Jun 2022 13:19:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment