Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34359 )
Change subject: mainboard: Add Lenovo ThinkPad T440p
......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34359/12/Documentation/mainboard/le...
File Documentation/mainboard/lenovo/t440p.md:
https://review.coreboot.org/c/coreboot/+/34359/12/Documentation/mainboard/le...
PS12, Line 38: - Cannot get the mainboard serial number
Are there any eeproms on smbus?
As I said at https://review.coreboot.org/c/coreboot/+/34359/12#message-984b10347baf70fd8e..., Lenovo has something they call it in UEFI a emulated eeprom, but I don't know how to initialize it to make it readable.
Now I can set DRIVER_LENOVO_SERIALS=n as a work around.
https://review.coreboot.org/c/coreboot/+/34359/12/src/mainboard/lenovo/t440p...
File src/mainboard/lenovo/t440p/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/34359/12/src/mainboard/lenovo/t440p...
PS12, Line 39: register "gen3_dec" = "0x00000000"
remove
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34359
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I56a6b94197789a83731d8b349b8ba6814bf57ca2
Gerrit-Change-Number: 34359
Gerrit-PatchSet: 12
Gerrit-Owner: Iru Cai (vimacs)
mytbk920423@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Iru Cai (vimacs)
mytbk920423@gmail.com
Gerrit-Reviewer: Iru Cai
mytbk920423@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 10 Oct 2019 13:49:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment