Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78131?usp=email )
Change subject: mb/lenovo/t520: Move selects from Kconfig.name to Kconfig ......................................................................
mb/lenovo/t520: Move selects from Kconfig.name to Kconfig
Selects should be done in the Kconfig file instead of Kconfig.name and not mixed over both files.
Change-Id: I6b71c7c5c9e32e21c757c0ed0e9c6bd9d58a4f75 Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/78131 Reviewed-by: Martin L Roth gaumless@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/lenovo/t520/Kconfig M src/mainboard/lenovo/t520/Kconfig.name 2 files changed, 6 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved
diff --git a/src/mainboard/lenovo/t520/Kconfig b/src/mainboard/lenovo/t520/Kconfig index a5af0db..2223b72 100644 --- a/src/mainboard/lenovo/t520/Kconfig +++ b/src/mainboard/lenovo/t520/Kconfig @@ -25,6 +25,12 @@ # Workaround for EC/KBC IRQ1. select SERIRQ_CONTINUOUS_MODE
+config BOARD_LENOVO_T520 + select BOARD_LENOVO_BASEBOARD_T520 + +config BOARD_LENOVO_W520 + select BOARD_LENOVO_BASEBOARD_T520 + if BOARD_LENOVO_BASEBOARD_T520
config VBOOT diff --git a/src/mainboard/lenovo/t520/Kconfig.name b/src/mainboard/lenovo/t520/Kconfig.name index cc622f0..d77afc8 100644 --- a/src/mainboard/lenovo/t520/Kconfig.name +++ b/src/mainboard/lenovo/t520/Kconfig.name @@ -1,7 +1,5 @@ config BOARD_LENOVO_T520 bool "ThinkPad T520" - select BOARD_LENOVO_BASEBOARD_T520
config BOARD_LENOVO_W520 bool "ThinkPad W520" - select BOARD_LENOVO_BASEBOARD_T520