31 May
2019
31 May
'19
8:55 a.m.
Martin Kepplinger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32617 )
Change subject: mb/lenovo/*: Add support for VBOOT on 12MiB devices ......................................................................
Patch Set 4: Code-Review+1
(1 comment)
fwiw, I think this is fine since we can add other vboot formats anytime later.
https://review.coreboot.org/#/c/32617/3/src/mainboard/lenovo/x230/board.fmd File src/mainboard/lenovo/x230/board.fmd:
https://review.coreboot.org/#/c/32617/3/src/mainboard/lenovo/x230/board.fmd@... PS3, Line 9: SMMSTORE(PRESERVE)@0x10000 0x40000 is that region really necessary? if so, why? sorry if that's a general or off-topic question.
--
To view, visit https://review.coreboot.org/c/coreboot/+/32617
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8a35a06ece1e9d57a2ef23970e61ae26fafce543
Gerrit-Change-Number: 32617
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Martin Kepplinger martink@posteo.de
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 31 May 2019 06:55:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment