Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37847 )
Change subject: Documentation/soc/amd: Add PSP integration information
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37847/3/Documentation/soc/amd/psp_i...
File Documentation/soc/amd/psp_integration.md:
https://review.coreboot.org/c/coreboot/+/37847/3/Documentation/soc/amd/psp_i...
PS3, Line 342:
Ack. […]
CB:37490 My suggestion was to move amdcompress outside util/cbfstool and into util/amdfwtool.
AFAICS the only thing cbfstool and amdcompress share is need of ELF headers, which itself is an external header.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37847
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I05187365158eb5c055be0d4a32f41324d2653f71
Gerrit-Change-Number: 37847
Gerrit-PatchSet: 4
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 07 Feb 2020 14:32:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-MessageType: comment