Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49016 )
Change subject: device: Select VGA_ROM_RUN for non-FSP solution with PCIE DGPU
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/49016/4/src/device/Kconfig
File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/49016/4/src/device/Kconfig@53
PS4, Line 53: discrete graphics card
I believe we need independent settings for integrated and discrete GFX. […]
I agree with Angel here, it might be simpler to split this up into different Kconfigs
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49016
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iecb2fcdb105af449bc20ad727759cdef17d5e376
Gerrit-Change-Number: 49016
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Stefan Reinauer
reinauer@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 05 Jan 2021 23:03:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment