Attention is currently required from: Maciej Pijanowski, Stefan Reinauer.
Hello Maciej Pijanowski,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/70105
to review the following change.
Change subject: util/ifdtool/Makefile: improve cross-compilation support ......................................................................
util/ifdtool/Makefile: improve cross-compilation support
INSTALL and PREFIX variables will not be overwritten. Also, mkidir was replaced by a tool from the INSTALL variable to be compatible with other cross-compilation buildsystems (like Yocto)
Signed-off-by: Maciej Pijanowski maciej.pijanowski@3mdeb.com Change-Id: Ia8dd67d18392e1e11d9160b187ef1a874d69ff5d --- M util/ifdtool/Makefile 1 file changed, 18 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/70105/1
diff --git a/util/ifdtool/Makefile b/util/ifdtool/Makefile index 83d19b8..c021069 100644 --- a/util/ifdtool/Makefile +++ b/util/ifdtool/Makefile @@ -2,9 +2,9 @@ # # SPDX-License-Identifier: GPL-2.0-only
-CC ?= gcc -INSTALL = /usr/bin/env install -PREFIX = /usr/local +CC ?= gcc +INSTALL ?= /usr/bin/env install +PREFIX ?= /usr/local
HOSTCC ?= $(CC) HOSTCFLAGS ?= $(CFLAGS) @@ -21,7 +21,7 @@ distclean: clean
install: $(PROGRAM) - mkdir -p $(DESTDIR)$(PREFIX)/bin + $(INSTALL) -d $(DESTDIR)$(PREFIX)/bin $(INSTALL) $(PROGRAM) $(DESTDIR)$(PREFIX)/bin
.PHONY: all clean distclean install