1 Apr
2021
1 Apr
'21
4:13 a.m.
Attention is currently required from: Chen-Tsung Hsieh, Tao Xia, Yu-Ping Wu. Xuxin Xiong has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51853 )
Change subject: mb/google/kukui: fix the issue of getting error panel_id ......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/c/coreboot/+/51853/comment/39b7e48d_1f29f14d PS3, Line 126: TODO
I'm fine either way.... […]
Hi Yu-Ping, Hung-Te, I had submit the CL in https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+..., coule you help review this? Thanks a lot!
--
To view, visit https://review.coreboot.org/c/coreboot/+/51853
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I63e0c8a2719462a9b979afe52a27c78b9fc804e8
Gerrit-Change-Number: 51853
Gerrit-PatchSet: 3
Gerrit-Owner: Xuxin Xiong xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Chen-Tsung Hsieh chentsung@chromium.org
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Tao Xia xiatao5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Chen-Tsung Hsieh chentsung@chromium.org
Gerrit-Attention: Tao Xia xiatao5@huaqin.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu yupingso@google.com
Gerrit-Comment-Date: Thu, 01 Apr 2021 02:13:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin hungte@chromium.org
Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com
Gerrit-MessageType: comment