Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33199 )
Change subject: sb/intel/common/Makefile: Use 'all' class to link files in all stages
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33199/11/src/southbridge/intel/comm...
File src/southbridge/intel/common/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/33199/11/src/southbridge/intel/comm...
PS11, Line 70: smm-y += rtc.c
Well, Jenkins doesn't seem to mind. But if this is intended, please mention
it in the commit message.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33199
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I65926046d941df3121c7483d69c0b4f7003d783e
Gerrit-Change-Number: 33199
Gerrit-PatchSet: 11
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 19 Oct 2019 18:25:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment