Attention is currently required from: Intel coreboot Reviewers, Julius Werner, Karthik Ramasubramanian, Subrata Banik.
Jérémy Compostella has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86336?usp=email )
Change subject: soc/intel/cmn/pmc: Add support for early power off ......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3:
Please hold review in this CL as I will refactor this CL […]
I disagree with #1 as detailed in the discussion found at the following link: [comment 21c234e0_b1965b7b](https://review.coreboot.org/c/coreboot/+/86336/comment/21c234e0_b1965b7b/).
Regarding point #2, it appears to be a more reasonable approach than your previous proposal. Given that the limitation is specific to the System on Chip (SoC), it is sensible to manage it within the SoC-specific codebase.
File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/86336/comment/9bacfd9a_0bc8a136?usp... : PS3, Line 635: __weak void platform_do_early_poweroff(void)
Can you tell me the name of the Intel SoC that supports early shutdown using PMC? Based on my knowledge, there are currently no Intel SoCs that support common code with early shutdown capabilities. However, we can consider implementing a SoC-specific override if any future SoC enables early shutdown.
I cannot provide you with a 100% guaranteed list of Intel SoCs where early shutdown is confirmed to be effective, as this scenario has not been formally tested, and I lack the resources to conduct such tests personally. However, based on my experience in the automotive industry working with SoCs like Apollo Lake, I believe that early shutdown was operational at early boot.