1 Apr
2025
1 Apr
'25
5:16 p.m.
Attention is currently required from: Sean Rhodes.
Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/87055?usp=email )
Change subject: mb/starlabs/starbook/mtl: Show the option to enable the GNA ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/starlabs/starbook/cfr.c:
https://review.coreboot.org/c/coreboot/+/87055/comment/f211d0ba_e32257bf?usp... : PS1, Line 259: #if CONFIG(SOC_INTEL_TIGERLAKE) || CONFIG(SOC_INTEL_ALDERLAKE) || CONFIG(SOC_INTEL_RAPTORLAKE)
needs `| MTL` here too or variable is unused
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/87055?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I568cb169f5266703e4422d77c0e0546a6d245ee2
Gerrit-Change-Number: 87055
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Rhodes sean@starlabs.systems
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Sean Rhodes sean@starlabs.systems
Gerrit-Comment-Date: Tue, 01 Apr 2025 15:16:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier matt.devillier@gmail.com