[coreboot-gerrit] Change in coreboot[master]: soc/intel/xeon_sp: Move debug macros to console/debug.h

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46093 )

Change subject: soc/intel/xeon_sp: Move debug macros to console/debug.h
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46093/1/src/soc/intel/xeon_sp/cpx/c... 
File src/soc/intel/xeon_sp/cpx/chip.c:

https://review.coreboot.org/c/coreboot/+/46093/1/src/soc/intel/xeon_sp/cpx/c... 
PS1, Line 4: 
           : #include <console/debug.h>
My only complaint is that I would also keep console/console.h for any file that uses a printk(), i.e. don't rely on the assumption that debug.h will include it.  This probably applies to all the .c files in this change but I didn't verify.