Huayang Duan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35164 )
Change subject: mediatek/mt8183: Use calibration result do fast calibration ......................................................................
Patch Set 12:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35164/7/src/soc/mediatek/mt8183/emi... File src/soc/mediatek/mt8183/emi.c:
https://review.coreboot.org/c/coreboot/+/35164/7/src/soc/mediatek/mt8183/emi... PS7, Line 370: if DUAL_FREQ_K : current_freqsel = freq_tbl[DRAM_DFS_SHUFFLE_3]; : params = &freq_params[DRAM_DFS_SHUFFLE_3]; : #else : current_freqsel = freq_tbl[DRAM_DFS_SHUFFLE_1]; : params = &freq_params[DRAM_DFS_SHUFFLE_1]; : #endif
int freq_index = DRAM_DFS_SHUFFULE_1; […]
Done
https://review.coreboot.org/c/coreboot/+/35164/7/src/soc/mediatek/mt8183/emi... PS7, Line 381: #if DUAL_FREQ_K
isn't this 'multiple frequency' than 'dual'? […]
Done
https://review.coreboot.org/c/coreboot/+/35164/7/src/soc/mediatek/mt8183/inc... File src/soc/mediatek/mt8183/include/soc/dramc_pi_api.h:
https://review.coreboot.org/c/coreboot/+/35164/7/src/soc/mediatek/mt8183/inc... PS7, Line 41: #define DUAL_FREQ_K 0
Move this to a KConfig.
Done