Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38853 )
Change subject: util: Remove viatool
......................................................................
Patch Set 2:
Patch Set 1:
Well, I believe viatool isn't used anymore. I think it was used with the vx900 code that got dropped after 4.11, so I don't know if this tool is useful to have.
That would be an argument for removing the tool altogether, which is a bigger change than this one. And yes, that might be the right course of action.
I checked, and no VIA code remains in coreboot master, so I believe it is best to drop this tool.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38853
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia7e11379a6db650b5190a056226a9101c2be7dec
Gerrit-Change-Number: 38853
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 17 Feb 2020 15:37:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment