Attention is currently required from: Eric Lai, Kapil Porwal, Shelley Chen, Subrata Banik.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79769?usp=email )
Change subject: vendorcode/google/chromeos: Use unsigned int for "factory_config" ......................................................................
Patch Set 3:
(1 comment)
File src/vendorcode/google/chromeos/chromeos.h:
https://review.coreboot.org/c/coreboot/+/79769/comment/1d98e418_2bd73f21 : PS3, Line 20: CHROMEOS_ERROR
Please name this something that more clearly connects it to factory config, this name is too gener […]
But it is not something that should be used more widely? It is specifically only for functions that return a 64-bit unsigned bitfield and want to encode an error in there, and you need to pick a value that you know cannot be a valid representation for those bit fields, so this kind of error value pretty much always needs to be tied to the specific function.
Other functions should generally be using `enum cb_err` to return errors, or maybe they return a size_t and use 0 to represent errors, or any of those other more normal error conventions.