Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34535 )
Change subject: lib: Call extract() only when initrd.size is more than 0
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34535/3/src/lib/fit_payload.c
File src/lib/fit_payload.c:
https://review.coreboot.org/c/coreboot/+/34535/3/src/lib/fit_payload.c@249
PS3, Line 249: size
I don't like that this will silently fail if ramdisk is present, but the size is zero. That's an invalid combination, so it should be an error. Print out an error saying that initrd size is zero.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34535
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85aa33d2c2846b6b3a58df834dda18c47433257d
Gerrit-Change-Number: 34535
Gerrit-PatchSet: 3
Gerrit-Owner: Asami Doi
d0iasm.pub@gmail.com
Gerrit-Reviewer: Asami Doi
d0iasm.pub@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 25 Jul 2019 19:03:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment