Stefan Reinauer has submitted this change. ( https://review.coreboot.org/c/em100/+/42843 )
Change subject: firmware.c: Fix 'dead assignment' ......................................................................
firmware.c: Fix 'dead assignment'
Dead assignment spotted out using clang-tools.
Change-Id: I44ca81ecee8ee9639b37a03e5a5b513cd07f4d10 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/em100/+/42843 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M firmware.c 1 file changed, 1 insertion(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/firmware.c b/firmware.c index f86362c..6bd044e 100644 --- a/firmware.c +++ b/firmware.c @@ -246,7 +246,7 @@ unsigned char page[256], vpage[256]; long fsize; unsigned char *fw; - int i, automatic = 0; + int i; int fpga_offset, fpga_len, mcu_offset, mcu_len; char fpga_version[MAX_VERSION_LENGTH + 1], mcu_version[MAX_VERSION_LENGTH + 1]; @@ -285,7 +285,6 @@ return 0; } memcpy(fw, data.autoupdate_file->address, fsize); - automatic = 1; } else { FILE *f;