Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38395 )
Change subject: drivers/i2c/at24rf08c: Use `smbus_block_write()`
......................................................................
Patch Set 1:
(1 comment)
Do you know, if this can even work?
https://review.coreboot.org/c/coreboot/+/38395/1/src/drivers/i2c/at24rf08c/a...
File src/drivers/i2c/at24rf08c/at24rf08c.c:
https://review.coreboot.org/c/coreboot/+/38395/1/src/drivers/i2c/at24rf08c/a...
PS1, Line 34: printk(BIOS_ERR, "Failed writing at24rf08c configuration!\n");
On the Lenovo T60, the write fails, and the error is shown.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38395
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c536410263b23cba2fa66605d7b0ff6c5dd20c1
Gerrit-Change-Number: 38395
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Tue, 14 Jan 2020 15:06:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment