Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33621 )
Change subject: soc/amd/stoneyridge: Add Merlin Falcon configuration ......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/33621/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33621/6//COMMIT_MSG@10 PS6, Line 10: makefile modify THE makefile
https://review.coreboot.org/c/coreboot/+/33621/6/src/soc/amd/stoneyridge/Kco... File src/soc/amd/stoneyridge/Kconfig:
https://review.coreboot.org/c/coreboot/+/33621/6/src/soc/amd/stoneyridge/Kco... PS6, Line 33: bool Here's how you add the prompt:
bool "Merlinfalcon binaries are present"
https://review.coreboot.org/c/coreboot/+/33621/6/src/soc/amd/stoneyridge/Kco... PS6, Line 327: bool Add a prompt here? Otherwise it will always be y for stoney and N for merlin falcon unless overridden in the mainboard.
https://review.coreboot.org/c/coreboot/+/33621/6/src/soc/amd/stoneyridge/Mak... File src/soc/amd/stoneyridge/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/33621/6/src/soc/amd/stoneyridge/Mak... PS6, Line 197: : ifeq ("$(wildcard $(SMUFWM_FN_FILE))","") Don't you want a build failure if the user wanted to include the file but doesn't have them in the right spot?