Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34424 )
Change subject: soc/amd/picasso: Update northbridge
......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34424/12/src/soc/amd/picasso/includ...
File src/soc/amd/picasso/include/soc/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/34424/12/src/soc/amd/picasso/includ...
PS12, Line 108: #define DF_F0_DEVID 0x15e8
Could you add comments defining what each data fabric is about? Like DRAM/MISC/PM and so on?
No, I prefer not to. The features don't line up nicely like in previous generations, and it's doubtful they'll get documented in the public PPR.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34424
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44a4a97765151fbcfe4c5d8de200e3e015aaaf2e
Gerrit-Change-Number: 34424
Gerrit-PatchSet: 14
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Comment-Date: Thu, 17 Oct 2019 23:13:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-MessageType: comment