Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33842 )
Change subject: src/superio/nuvoton: Add support for NCT5539D
......................................................................
Patch Set 11: Code-Review-1
(1 comment)
https://review.coreboot.org/#/c/33842/10/src/superio/nuvoton/common/early_se...
File src/superio/nuvoton/common/early_serial.c:
https://review.coreboot.org/#/c/33842/10/src/superio/nuvoton/common/early_se...
PS10, Line 78: 0x40
NCT6776F-D, NCT6791D and NCT5539D has the same set of values for this, so the switch code supposed t […]
no, this is simply not true. see patch set 33640
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33842
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7e979bde53ce3dac1a4f74e7e51a3c6a0149051c
Gerrit-Change-Number: 33842
Gerrit-PatchSet: 11
Gerrit-Owner: Pavel Sayekat
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Pavel Sayekat
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 30 Jun 2019 11:59:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Comment-In-Reply-To: Pavel Sayekat
Gerrit-MessageType: comment