Attention is currently required from: Kevin Chang. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51200 )
Change subject: mb/google/volteer/variant/lindar: Disable SA GV for EVT build MB ......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/google/volteer/variants/lindar/memory.c:
https://review.coreboot.org/c/coreboot/+/51200/comment/9ed83cab_c1f0e257 PS3, Line 72: if ((google_chromeec_get_board_version(&board_version) == 0) && (board_version == 1)) suspect code indent for conditional statements (8, 8)
File src/soc/intel/tigerlake/include/soc/romstage.h:
https://review.coreboot.org/c/coreboot/+/51200/comment/5cf5cb42_a905ef19 PS3, Line 10: void __weak memcfg_variant_init(FSPM_UPD *mupd); Using weak declarations can have unintended link defects