Attention is currently required from: Bao Zheng, Felix Held, Julius Werner, Marshall Dawson, Zheng Bao, ritul guru.
Maximilian Brune has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/85466?usp=email )
Change subject: amdfwtool: Set address mode of BIOS binary as context defines
......................................................................
Patch Set 9:
(1 comment)
Patchset:
PS9:
Do you use the default setting to build birman-plus. […]
Yes.
The address mode of the bios binary changes from relative to BIOS to relative to table.
That is also what I can see in this patch or am I missing something?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85466?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9c2f2983d03c913b28fbd87aa0925a32a4649d62
Gerrit-Change-Number: 85466
Gerrit-PatchSet: 9
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ritul guru
ritul.bits@gmail.com
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: ritul guru
ritul.bits@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 24 Feb 2025 23:52:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bao Zheng
fishbaozi@gmail.com
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com