Attention is currently required from: Alexander Couzens, Elyes Haouas, Nicholas Chin, Stefan Ott.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77738?usp=email )
Change subject: sb/intel/i82801{i;j}x/chip: Use boolean where appropriate ......................................................................
Patch Set 4:
(4 comments)
File src/southbridge/intel/i82801ix/chip.h:
https://review.coreboot.org/c/coreboot/+/77738/comment/191796bf_27acc19b : PS4, Line 59: unsigned int sata_clock_request : 1; : u I need to look into these.
https://review.coreboot.org/c/coreboot/+/77738/comment/b877b5bb_efd9e556 : PS4, Line 77: uint8_t pcie_hotplug_map[8]; This should be bool as well.
File src/southbridge/intel/i82801jx/chip.h:
https://review.coreboot.org/c/coreboot/+/77738/comment/cdb708ac_ba566eaf : PS4, Line 46: unsigned int sata_clock_request : 1; Sounds like it could be bool. I need to look into it.
https://review.coreboot.org/c/coreboot/+/77738/comment/d9ee0464_67a427c4 : PS4, Line 63: uint8_t pcie_hotplug_map[8]; This should be bool as well.