[coreboot-gerrit] Change in ...coreboot[master]: WIP: mediaek/mt8183: add panel driver for kukui p2

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32097 )

Change subject: WIP: mediaek/mt8183: add panel driver for kukui p2
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/32097/1/src/soc/mediatek/mt8183/dsi.c 
File src/soc/mediatek/mt8183/dsi.c:

https://review.coreboot.org/#/c/32097/1/src/soc/mediatek/mt8183/dsi.c@100 
PS1, Line 100: 
             : 	if (board_id() == 2)
             : 		data_rate = 1420000000;
should not do board_id identification inside mt8183 (SOC) code. this should be passed from somewhere else.

https://review.coreboot.org/#/c/32097/1/src/soc/mediatek/mt8183/dsi.c@191 
PS1, Line 191: mtk_dsi_reset
no need to identify between p1 and p2?