[coreboot-gerrit] Change in coreboot[master]: mb/google/hatch/variants/hatch: Set PCH Thermal Threshold value to 77...

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33147 )

Change subject: mb/google/hatch/variants/hatch: Set PCH Thermal Threshold value to 77 deg C
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33147/3/src/mainboard/google/hatch/... 
File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/33147/3/src/mainboard/google/hatch/... 
PS3, Line 191: on
> "bios should only allocated BAR for devices that it plan to use in bios space ..."
> yes, that's why it need to be "on", as LTT programming is done in "bios space".

no, thats not the point, LTT is just a register and BIOS for say won't use this thermal device. its not the TPM, Touch or Track pad device that BIOS might need to deal with and provide resources to OS.

LTT programming can even done in bootblock :) for that will i do pci enumeration in bootblock? :)