[coreboot-gerrit] [M] Change in coreboot[main]: soc/mediatek/mt8196: Add booker driver

[Dehui Sun (Code Review)]

Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yu-Ping Wu.

Dehui Sun has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85362?usp=email )

Change subject: soc/mediatek/mt8196: Add booker driver
......................................................................

Patch Set 9:

(5 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/85362/comment/d03489fc_c5fb3a7d?usp... :
PS9, Line 9: The MTK booker
> The MediaTek booker (the customized ARM CI-700)

Okay, This will be modified in the next release.

https://review.coreboot.org/c/coreboot/+/85362/comment/f60919d6_fb3e5145?usp... :
PS9, Line 15: it can
> `it needs to` ?

Okay, This will be modified in the next release.

https://review.coreboot.org/c/coreboot/+/85362/comment/ed564ac5_1f42b926?usp... :
PS9, Line 15: it can
            : set bit[3] (disable_cmo_prop) to 0 in the por_sbsx_cfg_ctl register of
            : each SBSX node.
> Does it mean that we need to set the bit 3 (disable_cmo_prop) to `0` in order to propagate the CMO c […]

Yes, the default value of the reg por_sbsx_cfg_ctl is 64'b1111111, we must clear bit3 to 0.

File src/soc/mediatek/mt8196/booker.c:

https://review.coreboot.org/c/coreboot/+/85362/comment/74188f42_a581767a?usp... :
PS9, Line 11: MCUSYS_PAR_WRAP_BASE
> just use `MCUCFG_BASE`

Okay, This will be modified in the next release.

https://review.coreboot.org/c/coreboot/+/85362/comment/e6a52a9d_f481870a?usp... :
PS9, Line 13: 0x00450000 + 0x0A00
> please define this

Okay, This will be modified in the next release.