[coreboot-gerrit] [S] Change in coreboot[main]: {lib, ec/google}: Add weak implementation for get_lid_switch()

[Kyösti Mälkki (Code Review)]

Attention is currently required from: Boris Mittelberg, Caveh Jalali, Jakub Czapiga, Karthik Ramasubramanian, Nick Vaccaro, Nick Vaccaro, Subrata Banik, Yu-Ping Wu.

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78076?usp=email )

The change is no longer submittable: All-Comments-Resolved is unsatisfied now.

Change subject: {lib, ec/google}: Add weak implementation for get_lid_switch()
......................................................................

Patch Set 8:

(1 comment)

File src/lib/bootmode.c:

https://review.coreboot.org/c/coreboot/+/78076/comment/58eb4ec5_a0c1fb26 :
PS8, Line 41: __weak int get_lid_switch(void)
This file bootmode.c is effectively added as:

all-y += bootmode.c.

At the same time, eg. samsung/lumpy has get_lid_switch() implementation in chromeos.c file added as:

romstage-y += chromeos.c
ramstage-y += chromeos.c

Such boards would incorrectly pick the weak / dummy implementation for other stages. I claim those boards could also have VBOOT_LID_SWITCH selected since they are actually Chromebooks with an implemented lid switch.

I don't mind you marking this as acked, just that I feel we should try to invent something better to detect such cases build-time.