Evan Green has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34176 )
Change subject: mb/google/hatch: Disable GPIO community dynamic clock gating
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34176/3/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/34176/3/src/mainboard/google/hatch/...
PS3, Line 98: Disable dynamic clock gating
Can you say why, like the old comment did. Also, as was mentioned on the bug, we need to understand how much power we're sacrificing here. It's possible there were a few flags that we could still leave on that helped power but didn't put us at risk to miss short pulses. I wanted to try the experiment in comment #52 of b/130764684, but hadn't had a chance to do it yet.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34176
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8f1ec8f7c31192bce2a761ec99b86638435dc27c
Gerrit-Change-Number: 34176
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Evan Green
evgreen@chromium.org
Gerrit-CC: Rajat Jain
rajatja@google.com
Gerrit-Comment-Date: Tue, 09 Jul 2019 20:32:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment