Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34777 )
Change subject: mediatek/mt8183: postpone dcxo low power mode setting
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34777/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34777/2//COMMIT_MSG@13
PS2, Line 13: mask request to disable unused power mode when modem is no longer be used.
So is the only reason why we need this that we're calling mt6358_init() before mtk_md_early_init()? Why don't we just move mtk_md_early_init() into romstage? It's just a 2-line function...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34777
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I047ebed615e874977ca211aafd52b5551c71b764
Gerrit-Change-Number: 34777
Gerrit-PatchSet: 2
Gerrit-Owner: Weiyi Lu
weiyi.lu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Ben Ho
Ben.Ho@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Weiyi Lu
weiyi.lu@mediatek.com
Gerrit-Reviewer: Weiyi Lu
weiyi.lu@mediatek.corp-partner.google.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: SJ Huang
sj.huang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Tue, 13 Aug 2019 00:31:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment