Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33754 )
Change subject: soc/amd/picasso: Remove all PSP runtime functions ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/33754/2/src/soc/amd/picasso/include/soc/pci_... File src/soc/amd/picasso/include/soc/pci_devs.h:
https://review.coreboot.org/#/c/33754/2/src/soc/amd/picasso/include/soc/pci_... PS2, Line 98: : : : : : :
Should this be removed? Picasso does have a PSP, what if in the future we need to access it? Sure, d […]
I don't anticipate needing to talk to the PSP from coreboot at this time. I plan to leave it to AGESA if it's necessary.
It's a different device/function. pci_devs.h will get a major overhaul in a later patch, and that will also force a lot of other changes throughout the picasso directory. Removing it here simplifies things.
Also note that the common/block/psp code currently assumes AGESA v5. So my goal here is to remove 100% of the PSP stuff.