Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38057 )
Change subject: security: Move TS_{START,END}_TPMINIT out of vboot
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38057/1/src/security/vboot/vboot_lo...
File src/security/vboot/vboot_logic.c:
https://review.coreboot.org/c/coreboot/+/38057/1/src/security/vboot/vboot_lo...
PS1, Line 324: antirollback_read_space_firmware
We're losing the time this function takes. Should we rename the #defines and add new ones that are just inside tpm_setup()?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38057
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib1048f7b7a5903d186cdd750822b4bc8ea7dc665
Gerrit-Change-Number: 38057
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 07 Jan 2020 19:33:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment