[coreboot-gerrit] Change in coreboot[master]: mb/google/hatch/variants/hatch: Set PCH Thermal Threshold value to 77...

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33147 )

Change subject: mb/google/hatch/variants/hatch: Set PCH Thermal Threshold value to 77 deg C
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33147/3/src/mainboard/google/hatch/... 
File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/33147/3/src/mainboard/google/hatch/... 
PS3, Line 191: on
> wrong, we should never operate on devices that are marked off. […]

i have replied to your concern already in original CL. It might be still okay to skip PCI enumeration of some devices in BIOS space because kernel has capability to handle pci enumeration. IMHO, bios should only allocated BAR for devices that it plan to use in bios space and if we have any fixed resource  guideline in SoC like PMC, ACPI BAR to protect from OS to override.