Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44234 )
Change subject: cpu/intel/slot_1: Factor out per-CPU Kconfig ......................................................................
Patch Set 3:
Patch Set 3: Code-Review+1
I thought about this, you made this happen. 😊
Although I would put some other patches in this train first, namely the one unifying 65x/67x and the one unifying 68x/6bx. But timeless binary doesn't change before and after, so you have my vote.
Thanks for the review! I noticed the redundancy in slot_1 CPUs while I was replacing Makefile with preprocessor, and then handled it. That's why the order is out of whack.
I don't know if you have seen yet, but I'd appreciate some testing on CB:44238 and CB:44239 if possible. The idea is to unify the CPUs in CB:44241 to remove some redundant code.