Attention is currently required from: Tim Wawrzynczak, EricR Lai. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61201 )
Change subject: mb/google/brya/var/banshee: update gpio settings ......................................................................
Patch Set 1:
(7 comments)
File src/mainboard/google/brya/variants/banshee/gpio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138583): https://review.coreboot.org/c/coreboot/+/61201/comment/a687aed1_d6f70a80 PS1, Line 63: PAD_NC(GPP_B15, NONE), trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138583): https://review.coreboot.org/c/coreboot/+/61201/comment/57deb134_381d3434 PS1, Line 74: PAD_CFG_NF(GPP_C0, NONE, DEEP, NF1), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138583): https://review.coreboot.org/c/coreboot/+/61201/comment/b6f01533_191bd8fb PS1, Line 74: PAD_CFG_NF(GPP_C0, NONE, DEEP, NF1), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138583): https://review.coreboot.org/c/coreboot/+/61201/comment/8fd26f08_a70d877c PS1, Line 75: /* C1 : SMBDATA ==> DDR_SMB_DATA */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138583): https://review.coreboot.org/c/coreboot/+/61201/comment/ca0e5507_145fb46c PS1, Line 76: PAD_CFG_NF(GPP_C1, NONE, DEEP, NF1), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138583): https://review.coreboot.org/c/coreboot/+/61201/comment/db2e8851_b816799b PS1, Line 76: PAD_CFG_NF(GPP_C1, NONE, DEEP, NF1), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138583): https://review.coreboot.org/c/coreboot/+/61201/comment/171daea0_6a879430 PS1, Line 77: /* C2 : SMBALERT# ==> GPP_C2_STRAP */ code indent should use tabs where possible