[coreboot-gerrit] Change in coreboot[master]: soc/intel/alderlake: Add GPIOs for Alder Lake SOC

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45571 )

Change subject: soc/intel/alderlake: Add GPIOs for Alder Lake SOC
......................................................................

Patch Set 5: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/45571/2/src/soc/intel/alderlake/gpi... 
File src/soc/intel/alderlake/gpio.c:

https://review.coreboot.org/c/coreboot/+/45571/2/src/soc/intel/alderlake/gpi... 
PS2, Line 66: static const struct pad_community adl_communities[] = {
> Looks like these GPIO definitions are specific to ADL PCH-LP. […]

for cannonlake, we ended up with two headers ...defs_cnp_h.h & ...defs.h. and then a CONFIG to select between them; not the prettiest though, we may be able to think of something better