[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/common: Skip SoC GT programming based on CONFIG_SKIP_GRAPHI...

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33189 )

Change subject: soc/intel/common: Skip SoC GT programming based on CONFIG_SKIP_GRAPHICS_ENABLING
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/33189/1/src/soc/intel/icelake/graphics.c 
File src/soc/intel/icelake/graphics.c:

https://review.coreboot.org/#/c/33189/1/src/soc/intel/icelake/graphics.c@48 
PS1, Line 48: DDI_A_4_LANES
> no such way, it might only required for initial PO days I'm not sure what bothers you ? in soc po, w […]

If it gets merged, it adds maintenance burden. If it's only for early
development days, I wonder why you would enable it (add PCI ID to
common/blocks/graphics), then add a Kconfig to disable it again. It
seems very odd and is already confusing in review, most likely more
confusing when somebody tries to read and understand the code.