Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38822 )
Change subject: mb/google/kukui: Add panel for Kakadu
......................................................................
Patch Set 9: Code-Review+2
(3 comments)
https://review.coreboot.org/c/coreboot/+/38822/4/src/mainboard/google/kukui/...
File src/mainboard/google/kukui/panel_kakadu.c:
https://review.coreboot.org/c/coreboot/+/38822/4/src/mainboard/google/kukui/...
PS4, Line 4: 2019
2020?
Ack
https://review.coreboot.org/c/coreboot/+/38822/3/src/mainboard/google/kukui/...
File src/mainboard/google/kukui/panel_params/panel-BOE_TV105WUM_NW0.c:
https://review.coreboot.org/c/coreboot/+/38822/3/src/mainboard/google/kukui/...
PS3, Line 25: .pixel_clock = 156298,
: .lvds_dual_channel = 0,
: .refresh = 60,
: .ha = 1200, .hbl = 164, .hso = 60, .hspw = 24,
: .va = 1920, .vbl = 26, .vso = 14, .vspw = 2,
patch 8 follows vendor's confirmation.
Ack
https://review.coreboot.org/c/coreboot/+/38822/3/src/mainboard/google/kukui/...
PS3, Line 35: INIT_DCS_CMD
patch 8 follows vendor's confirmation.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38822
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I394b8cafa8be40e5fd6bf8ceb81b520df73718a4
Gerrit-Change-Number: 38822
Gerrit-PatchSet: 9
Gerrit-Owner: Casper Chang
casper.chang@bitland.corp-partner.google.com
Gerrit-Reviewer: Casper Chang
casper.chang@bitland.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 14 Feb 2020 06:47:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Comment-In-Reply-To: Casper Chang
casper.chang@bitland.corp-partner.google.com
Gerrit-MessageType: comment