Attention is currently required from: Arthur Heymans, Angel Pons, Evgeny Zinoviev, Alexander Couzens, Patrick Rudolph.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56912 )
Change subject: nb/intel/sandybridge: Add a chipset devicetree
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/dell/snb_ivb_workstations/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/56912/comment/90c13466_39bf0ba2
PS5, Line 6: device lapic 0xacac off end
I quess you need a device under chip/? Just remember to address these too before sconfig grammar removes keyword lapic.
CB:59316 does that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56912
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9c5b6f25b779e28b6719cf70455ff0f1a916ad87
Gerrit-Change-Number: 56912
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Evgeny Zinoviev
me@ch1p.io
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 25 Nov 2022 16:45:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment