Attention is currently required from: Johnny Lin, Jingle Hsu, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49917 )
Change subject: arch/x86/smbios: Let SMBIOS type 9 be able to write slot ID
......................................................................
Patch Set 5:
(2 comments)
File src/mainboard/ocp/deltalake/ramstage.c:
https://review.coreboot.org/c/coreboot/+/49917/comment/93d4fcd5_542d6183
PS5, Line 108: 1
You can derive these numbers from the array indices:
for (index = 0; index < ARRAY_SIZE(slotinfo); index++) {
const u16 slot_id = index + 1;
/* other code here */
}
https://review.coreboot.org/c/coreboot/+/49917/comment/2aa86af8_d1bade4e
PS5, Line 238: .
The mainboard part is correct.
I don't think this syntax is standard C...
I'd prefer if the PCIe config changes were done in a separate commit.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49917
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9bf2e3b1232637a25ee595d08f8fbbc2283fcd5d
Gerrit-Change-Number: 49917
Gerrit-PatchSet: 5
Gerrit-Owner: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Attention: Patrick Rudolph
Gerrit-Comment-Date: Tue, 09 Mar 2021 10:43:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Johnny Lin
Johnny_Lin@wiwynn.com
Comment-In-Reply-To: Patrick Rudolph
Gerrit-MessageType: comment