Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32619 )
Change subject: util/inteltool: Add Kabylake E3-1200 MSRs ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/#/c/32619/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32619/5//COMMIT_MSG@7 PS5, Line 7: util/inteltool: Add Kabylake E3-1200 MSRs Add Kabylake E3-1200 support as you do more than adding MSRs
https://review.coreboot.org/#/c/32619/5/util/inteltool/cpu.c File util/inteltool/cpu.c:
https://review.coreboot.org/#/c/32619/5/util/inteltool/cpu.c@1548 PS5, Line 1548: /*{ 0x0180, "IA32_ENERGY_PERF_BIAS"}, please remove commented code. It looks like write only registers are allowed to be listed in that way.
https://review.coreboot.org/#/c/32619/5/util/inteltool/inteltool.c File util/inteltool/inteltool.c:
https://review.coreboot.org/#/c/32619/5/util/inteltool/inteltool.c@139 PS5, Line 139: "7th generation (Kaby Lake family) Core Processor Xeon E3-1200"}, missing space