[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/braswell/acpi/lpc.asl: Allocate used ROM size only

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31822 )

Change subject: soc/intel/braswell/acpi/lpc.asl: Allocate used ROM size only
......................................................................

Patch Set 4:
> Patch Set 4:
> > Patch Set 4:
> > > Now that I think about it again, somehow you managed to
> > > build patch set 1 and also Jenkins to build patch set 2.
> > > So maybe it is fixed already in a newer version of the
> > > compiler and some Jenkins node still runs an old version?
> >
> > Turned out that depending on what spurious numbers end up
> > in the byte stream, it sometimes results in a decompilation
> > warning, sometimes in an error. And we only checked for
> > warnings ^^ cf. CB:32469. This explains why we got different
> > results for the differently placed parentheses.
>
> I checked results of the failing situation. 
> build\dsdt.dsl is created only containing:
> "Error: Unknown opcode 0xFE at table offset" and "Could not parse ACPI tables, AE_AML_BAD_OPCODE"
>
> I did not check what IASL reporting.

IMO this fix is ready to review/merge. 
Any comments?