You-Cheng Syu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30975 )
Change subject: mediatek: Refactor I2C code among similar SOCs ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/30975/2/src/soc/mediatek/common/i2c.c File src/soc/mediatek/common/i2c.c:
https://review.coreboot.org/#/c/30975/2/src/soc/mediatek/common/i2c.c@195 PS2, Line 195: bus you can directly pass `regs` as parameter into `mtk_i2c_dump_info`
https://review.coreboot.org/#/c/30975/2/src/soc/mediatek/common/i2c.c@232 PS2, Line 232: uint8_t bool
https://review.coreboot.org/#/c/30975/2/src/soc/mediatek/common/i2c.c@234 PS2, Line 234: if (left_count >= 2 && : !(seg[0].flags & I2C_M_RD) && : (seg[1].flags & I2C_M_RD) && : seg[0].slave == seg[1].slave) : return 1; : else : return 0; directly return the expression